Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectCategoricalOption mutation for Phase 2 Store Refactor #366

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Feb 17, 2023

This PR closes #274 by implementing the following:

  1. selectCategoricalOption mutation in the store that takes a column name, option value and raw value and a) creates a valueMap object on dataDictionary.annotated.<column_name> if it does not exist, and b) assigns the raw value and option value as a key/value pair in the valueMap object.
  2. Three unit tests in store-mutation-selectCategoricalOption.cy.js that test a) if the value map is created when it does not yet exist, b) if the option (annotated) value is set in the value map for the raw value, and c) ensures a previously entered option value can be overwritten in the value map.
  3. annot-categorical component and its component test in annot-categorical.cy.js are updated to reflect changes for the new selectCategoricalOption mutation

@jarmoza jarmoza added annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Feb 17, 2023
@jarmoza jarmoza requested a review from rmanaem February 17, 2023 17:38
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏼‍🍳 🥯

@jarmoza jarmoza merged commit 28854e8 into dev_components_talk_to_store_directly Feb 20, 2023
@jarmoza jarmoza deleted the jarmoza-274 branch February 20, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants