-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getHarmonizedPreview getter for Phase 2 Refactor #368
Conversation
@rmanaem NOTE: Something is currently preventing our e2e tests from running. |
@rmanaem Just pushed the e2e yaml change in a new commit. Looks like we're in the green now for tests here too. |
@@ -53,10 +53,9 @@ | |||
|
|||
...mapGetters([ | |||
|
|||
"getPreviewValues", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for removing getPreviewValues
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getPreviewValues
was a to-be-implemented getter placed in the initial refactor of this file. At the moment it's necessary because it's called by the validationItems
function in annot-continuous-values
, but this will be removed in my next PR for #336 as I've decided to just use the mappedColumns
getter to retrieve the same information this unimplemented function would have.
@rmanaem PR requested changes committed. And tests are good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🏼🍳 🥯
This addresses #272 by implementing the following:
getHarmonizedPreview
which takes a column name and a data table value and produces a transformed version of that value given the transformation heuristic assigned to the given column. Of note, for this new implementation of functionality that was contained in the previous componentannot-age-values
is thatisoyear
transformation is currently being left (commented) out so it can be more fully addressed in a more robust way in its own new issue.appSetting
store field as mentioned in our Miro board draft of the store refactor. Currently this only contains themissingValueLabel
for the'string'
transformation heuristic.store-getter-getHarmonizedPreview.cy.js
annot-continuous-values
component and its test fileannot-continuous-values.cy.js