Feature for Phase 2 Refactor: Transform Heuristics for continuous values are now selectable by column #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarmoza
added
annotation page
data store
feat:improve
|
@jarmoza Regarding the issue with testing, was it the same issue we had in the past the one we have in |
|
Thanks @rmanaem. Will take a look at that branch's tests and see if I can note any similarities. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #336.
annot-continuous-valuescomponent (that is used on the annotation page tab, currently exclusively for 'Age'-categorized columns) now features one tab per columnannot-continuous-values.cy.jshave been reworked and extended for the new featureNOTE: @rmanaem There was something happening in the testing that I could not explain. The reason that the
storevariable is initialized each time in thebeforeEachfunction is because its function definitions instore.getterswere seemingly being wiped by (at least) the first individual test. This is difficult to debug becauseJSON.stringifywill not display functions defined on an object. Not sure this is necessarily worth our time to looking into, but if you can see something that might have caused that behavior please point it out.