Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 2 refactor: Column linking/unlinking alters data dictionary #379

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Phase 2 refactor: Column linking/unlinking alters data dictionary #379

merged 2 commits into from
Mar 16, 2023

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Mar 16, 2023 •
edited
Loading

This PR implements #376.

  • Unlinking a column from a category either reverts to the version of the column entry in dataDictionary.userProvided.<column-name> or if one hasn't been provided the default { description: "" }
  • Linking a column to a category initializes dataDictionary.annotated.<column-name> to { description: "" }

Unit tests for alterColumnCategoryMapping now use a beforeEach to load up a store object and new tests for the above implementation have been added.

@jarmoza jarmoza added categorization page annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Mar 16, 2023
@jarmoza jarmoza requested a review from rmanaem March 16, 2023 18:31
@jarmoza jarmoza changed the title Phase 2 refactor: Column unlinking reverts data dictionary entry for column to user provided version Phase 2 refactor: Column linking/unlinking alters data dictionary Mar 16, 2023
rmanaem
rmanaem approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

@jarmoza jarmoza merged commit 15f6c12 into dev_components_talk_to_store_directly Mar 16, 2023
@jarmoza jarmoza deleted the jarmoza-column-unlinking branch March 16, 2023 19:35
@jarmoza jarmoza mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
annotation page categorization page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
Neurobagel
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarmoza @rmanaem