Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 Refactor: Missing values functionality + integration with Annotation page #382

Merged

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Mar 21, 2023

This implements #381 along with a few adjustments for the missing values refactor. There is also some cleanup - removal of now-extraneous functions, removal of old comments, and updates to relevant unit tests

annot-continuous-values.vue

  • Restores missing value functionality (mark and unmark) to the annot-continuous-values component

annot-missing-values.cy.js

  • Removed an old mock getter for the value description (now called getValueDescription)

store-getter-getMissingValues.cy.js

  • Update to the unit tests given new way missingValues key in the data dictionary is initialized (see index.js for more info)

store-mutation-initializeDataDictionary.cy.js

  • Update to the unit tests given new initialization for the data dictionary with missing values

annotation.vue

  • Removing no longer necessary imports
  • Removing commented out code

index.js

  • missingValues for columns in dataDictionary.annotated are now initialized inside initializeDataDictionary. The reasoning behind this is that this results in cleaner code down the line where we don't have to continually check for the missingValues list's existence
  • When a column is linked or unlinked to a category, columns in dataDictionary.annotated are now reverted to their default/userProvided values + new empty missingValues list

@jarmoza jarmoza marked this pull request as draft March 21, 2023 16:23
@jarmoza jarmoza requested a review from rmanaem March 21, 2023 16:45
@jarmoza jarmoza added annotation page maint:refactor Simplifying or restructuring existing code or documentation. labels Mar 21, 2023
@jarmoza jarmoza marked this pull request as ready for review March 21, 2023 16:45
store/index.js Outdated Show resolved Hide resolved
@jarmoza
Copy link
Contributor Author

jarmoza commented Mar 22, 2023

@rmanaem Changes pushed.

Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

@jarmoza jarmoza merged commit 83295b9 into dev_components_talk_to_store_directly Mar 22, 2023
@jarmoza jarmoza deleted the jarmoza-missingvalues-cleanup branch March 22, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation page maint:refactor Simplifying or restructuring existing code or documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants