Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented updateAnnotationCount mutation #389

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Implemented updateAnnotationCount mutation #389

merged 6 commits into from
Mar 31, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Mar 30, 2023 •
edited
Loading

This PR includes:

  • Implementation of updateAnnotationCount mutation
    • A categorical column is considered annotated if:
      • It contains valueMap
      • Its valueMap is not empty
    • A continuous column is considered annotated if:
      • It contains transformationHeuristic
      • Its transformationHeuristic is not null
  • updateAnnotationCount unit-test
  • Modification made to selectCategoricalOption mutation, if the empty option from the v-select is selected rawValue is removed from the valueMap

Closes #388

@rmanaem
Implemented updateAnnotationCount mutation
67359b0
@rmanaem
Updated annot-categorical and annot-continuous-values components
37d5997 
Components will now call `updateAnnotationCount` mutation on `input`
event of `v-select`
@rmanaem
Modified updateAnnotationCount and selectCategoricalOption mutations
09ce9c5 
- `selectCategoricalOption`: If the empty option from the v-select is selected the rawValue is
removed from `valueMap`
- `updateAnnotationCount`: Modified conditions for incrementing the `annotationCount`
@rmanaem
Implemented unit-test for updateAnnotationCount mutation
0891d4e
@rmanaem rmanaem requested a review from jarmoza March 30, 2023 19:03
@rmanaem rmanaem self-assigned this Mar 30, 2023
jarmoza
jarmoza suggested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@jarmoza jarmoza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few small change requests, but more important is that you need to adjust the annot-categorical and annot-continuous-values component tests. They are currently not passing, and possibly also explains the github Cypress hang.

store/index.js Show resolved Hide resolved
store/index.js Outdated Show resolved Hide resolved
@rmanaem rmanaem requested a review from jarmoza March 31, 2023 15:55
jarmoza
jarmoza approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

@rmanaem rmanaem merged commit b73eb4d into dev_components_talk_to_store_directly Mar 31, 2023
@rmanaem rmanaem deleted the feat-388 branch March 31, 2023 18:30
@jarmoza jarmoza mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmoza jarmoza jarmoza approved these changes

Assignees

@rmanaem rmanaem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmanaem @jarmoza