Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the bug that made download page unreachable from annotation page #396

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fixed the bug that made download page unreachable from annotation page #396

merged 2 commits into from
Apr 5, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Apr 5, 2023

This PR includes the fix for #394.

Changes include:

  • Implemented a case for the download page in the switch statement of getNextPage getter in index.js
  • Implemented condition for displaying next-page component in default.vue layout component

Closes #394

jarmoza
jarmoza approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@jarmoza jarmoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳

@rmanaem rmanaem merged commit f7edf2d into dev_components_talk_to_store_directly Apr 5, 2023
@rmanaem rmanaem deleted the bug-394 branch April 5, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmoza jarmoza jarmoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmanaem @jarmoza