-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented getter to create JSON representation of continuous column #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmanaem Aside from the suggestion for alphabetizing object keys, I think the only major change to consider is why the levels and missing values test were removed from the categorical options getter tests in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🍳
Closes #407
Changes proposed in this pull request:
transformationHeuristics
according to this commentgetTransformOptions
gettergetTransformOptions
getter's unit testgetContinuousJsonOutput
gettergetContinuousJsonOutput
gettergetCategoricalJsonOutput
getter's unit testChecklist
[ENH]
,[BUG]
,[DOC]
,[INFRA]
,[MAINT]
)Closes #XXXX
For new features:
For bug fixes: