Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE] add ESLint and prettier #75

Merged
merged 4 commits into from
Mar 22, 2022
Merged

[STYLE] add ESLint and prettier #75

merged 4 commits into from
Mar 22, 2022

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Mar 21, 2022

This adds:

  • ESLint as a code linter
  • vue specific ESLint rules and the corresponding plugins
  • config for ESLint and ignore file
  • prettier as a code formatter
  • dependencies for all of this, plus dependencies for editorconfig (needs npm install in vscode to work)

This is related to what we discussed in #74.
I think there is a tradeoff between having something going now and immediately adopting a very strict style guide. I prepared some rules that I think would make sense to adopt eventually (e.g. airbnb style guide) but commented out for now. There are no linting checks to run the code, so all linting warning and errors can be ignored for now.

Using all default configuration. We will revisit the rules.

Resolves #74
also comment out every non-vue specific rule to keep
linting errors to a minimum for now
@surchs surchs requested a review from jarmoza March 21, 2022 02:09
@surchs surchs mentioned this pull request Mar 21, 2022
2 tasks
@surchs
Copy link
Contributor Author

surchs commented Mar 22, 2022

@jarmoza as we had discussed on slack and #76, I'll merge this so we can use the linter in the open PRs

@surchs surchs merged commit 1ce98bd into master Mar 22, 2022
@surchs surchs deleted the maint-add-linter branch April 14, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant