Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to integrate annotation page components and global store #84

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Mar 23, 2022

Integrating the recent additions to the annotation page with the elements of the global store.

  • columnToCategoryMap and dataTable are now used by annotation page components.
  • dataTable.original is read by annotation page components and when annotation changes are made via writeTable on annotation.vue changes are made to dataTable.annotated
  • writeColumn was rewritten to call the unlink column with category action from the store
  • A fix was put into place where to align the name of the assessment category on the categorization page with the annotation page. It's called 'Assessment Tool'.

@jarmoza jarmoza requested a review from surchs March 23, 2022 22:04
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jarmoza: fantastic stuff 🎉. Checked functionality, everything works. Agree on all the changes. Let's merge this!

@jarmoza jarmoza merged commit 6d588c3 into master Mar 24, 2022
@surchs surchs deleted the init-store-glue branch March 24, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants