Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a layout for the tool and moving navbar to the layout #86

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

jarmoza
Copy link
Contributor

@jarmoza jarmoza commented Mar 24, 2022

A layout vue template has been created in layouts/default.vue and tool-navbar has been moved outside of the pages and into that default layout.

As such pages are no longer responsible for generating the component and only have to worry about setting the current page via store function setCurrentPage.

The store now maintains a member currentPage for the navbar component.

@jarmoza jarmoza requested a review from surchs March 24, 2022 15:45
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @jarmoza, thanks for the PR. I think this makes things look very nice and clean! Confirmed that it works and agreed with the changes to the code

@jarmoza jarmoza merged commit 71b9270 into master Mar 24, 2022
@jarmoza jarmoza deleted the new-navbar-layout branch March 24, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants