[FEAT] add discrete value annotation #87
Conversation
- vue-bootstrap does not have a good option for drop-down selection with string autocompletion so we're using https://vue-select.org/ here instead
- linked to the category-sex.vue sub-page - passing (for now) hardcoded data
- this allows us to map values like those in the sex category to a set of predefined choices. - connected to the annotation page - added a button to trigger the updating of the datatable
|
ok @jarmoza, I think this works now as we would like it to. Ready for your review! |
|
@surchs Just tested this. I added categorized as 'sex' the actual 'sex' column and two other columns. Proceeding to annotation, I mark the 'M' as 'male' and the 'F' as 'female' and the blank value as 'missing value'. However, when I removed the miscategorized columns the button remains disabled. This means that column removal must be able to indicate that the One good point on that last action is that those miscategorized columns are actually unlinked from the 'sex' category on the categorization page when I navigate back to it. |
|
@surchs Let me know if you have any thoughts on my recent comment. The easiest way would be to utilize the What could/should be happening is that after a function that could change the page state - i.e. clear to proceed to the download page - a call should be made to change the page's state and in turn the actions that should follow that particular state change. |
|
@jarmoza: |
|
@jarmoza: I can confirm that this does not currently work:
The problem was that the method to enable / disable the button did not react to the number of columns changing and was still checking whether the unique values of the deleted column would be annotated (which they of course could never be), thus being forever stuck in a "not all annotated" state. One fix for this is to just recreate the valueMapper that is being checked to determine the annotation status with a watcher whenever the columns change. This works, in the sense that now we determine the annotation status only based on the currently selected columns. However, we now have another problem: because we are using the v-select dropdown component inside scoped slots, and because v-model does not work inside scoped slots (see this stackoverflow and the linked issue from vue) we are using the This does not happen if you navigate away from the page and come back, but that's no good. So in short, I think we need to not throw out the valueMapper and re-initialize as emtpy, but rather pick and choose what should remain and what should be removed. |
- before this commit, the value mapper was initialized onMount with all the columns mapped to the activeCategory at that time - if the relevant columns change later (particulalry when one is deleted), the valueMapper wouldn't update - this meant that we would never be able to enable the upload button because it would always be waiting for the unique elements of the deleted column to be annotated. Changes: - added a watcher for relevantColumns computed prop - when relevantColumns changes, the valueMapper gets updated - we detect the columns that were removed and delete the corresponding keys from the ValueMapper - to delete the keys, we use the Vue.delete method for all this to remain reactive.
There was a problem hiding this comment.
Now the functionality is fixed - and this is good enough for the demo. Obviously we are going to want to revisit internal implementation and other issues with this code post-demo.
I'm going to refrain from making detailed comments on the code with that stipulation.
|
OK, thanks @jarmoza. I will merge this now then. |
This PR adds a drop-down based functionality for mapping discrete values to a set of available choices.
For now we use this only for the sex category