-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Extended isolation forest #101
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 86.99% 87.68% +0.69%
==========================================
Files 26 28 +2
Lines 2153 2323 +170
==========================================
+ Hits 1873 2037 +164
- Misses 280 286 +6
☔ View full report in Codecov by Sentry. |
@SUKI-O you might be interested to see how your work in #75 enables this new algorithm to be easily added! "Extended Isolation Forest". The algorithm we add is a slight variation, but essentially almost the same. If you're interested, feel free to read the paper in the GH issue and then if you want, you can implement an example showing how it performs relative to IsolationForest on Gaussian blob data, and sinusoidal data. If you're interested in looking at other GH issues to solve, though we can take a look at other issues that might be of interest as well! |
Can I get started with this issue or tracking constant feature #115 is a higher priority? |
We need to finish the thread here first: #75 (comment) |
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@SUKI-O may you review this PR and code if you have some time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Figures lgtm
Okay in this goes! Feel free to look at the code and open up a GH issue if you have any questions/comments/concerns |
Fixes #98
Depends on the completion of #75
Basically replicates the figures from: https://github.com/sahandha/eif/blob/master/Notebooks/EIF.ipynb.
The actual implementation is trivial because it is just a case of extremely randomized oblique trees.
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting