-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add StreamDecisionForest class for streaming trees #116
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 87.68% 87.71% +0.02%
==========================================
Files 28 30 +2
Lines 2323 2426 +103
==========================================
+ Hits 2037 2128 +91
- Misses 286 298 +12
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP, will add some unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good after the fix in fork. Can we merge this? @adam2392
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov states that there are certain LOC not tested. Specifically around the swapping trees logic. Might be useful for code (and your paper) to think of a few unit-tests. A naive one that comes to mind is:
- the performance should improve as you stream iris data in w/ swaps, relative to non-swapping.
Can you also add a changelog entry?
Otw LGTM
@adam2392 I'm actually considering removing the tree swapping because it barely has any performance influences. I think I will remove it from this time of paper submission. |
Thanks @PSSF23 ! |
Related to #107
Changes proposed in this pull request:
sktree.experimental.StreamDecisionForest
for streaming tree testsBefore submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting