Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, BUG] Consistency of train/test samples in forest HT #135

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Oct 6, 2023

Changes proposed in this pull request:

  • fixes a bug in consistency of train/test samples when random_state is not set in ForestHT

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@sampan501 sampan501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running these with my code, will let you know if I find any bugs

Signed-off-by: Adam Li <adam2392@gmail.com>
@sampan501
Copy link
Member

It's been running for about an hour and no warnings or errors yet, so I think it should be fixed!

@sampan501 sampan501 self-requested a review October 6, 2023 19:25
@sampan501
Copy link
Member

I think upon merging, this fix should be pushed immediately to PyPi since it should effect everyone'e results

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 2162bae into main Oct 9, 2023
23 of 24 checks passed
@adam2392 adam2392 deleted the mightfix branch October 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants