Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for MIGHT p-value shuffling all columns by default #140

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

sampan501
Copy link
Member

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after minor fixes

sktree/stats/forestht.py Outdated Show resolved Hide resolved
sktree/stats/tests/test_forestht.py Show resolved Hide resolved
@adam2392
Copy link
Collaborator

Maybe add a small changelog, as I will release this in v0.3.

It is fixable in v0.2.1 by just manually passing covariate_index=np.arange(X.shape[1], dtype=int) for now.

@adam2392
Copy link
Collaborator

The error in test_small_dataset_independent can be fixed by removing the line testing the stat == 0.

@adam2392
Copy link
Collaborator

You should also run black, isort, and linters

poetry run poe format
poetry run poe lint
poetry run poe type_check

sampan501 and others added 3 commits October 10, 2023 16:43
Co-authored-by: Adam Li <adam2392@gmail.com>
Co-authored-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Collaborator

The current unit-test CI failures are unrelated and resolved in #129

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Collaborator

black was updated. I re-ran it w/ the updated version on in d849605.

Perhaps you're running an older version @sampan501

sktree/stats/forestht.py Outdated Show resolved Hide resolved
@adam2392 adam2392 merged commit 042cd02 into main Oct 11, 2023
23 of 24 checks passed
@adam2392 adam2392 deleted the might-pvalue-fix branch October 11, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants