Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adding citation file #144

Merged
merged 9 commits into from
Oct 17, 2023
Merged

[DOC] Adding citation file #144

merged 9 commits into from
Oct 17, 2023

Conversation

adam2392
Copy link
Collaborator

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
CITATION.cff Outdated
Comment on lines 8 to 11
- given-names: Adam
family-names: Li
affiliation: 'Department of Computer Science, Columbia University, New York, NY, USA'
orcid: 'https://orcid.org/0000-0001-8421-365X'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @PSSF23 @SUKI-O @sampan501 please push a commit, or comment w/ what should be added for your name.

Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (983b846) 89.73% compared to head (ccb0149) 89.73%.

❗ Current head ccb0149 differs from pull request most recent head 6e7b7b0. Consider uploading reports for the commit 6e7b7b0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          41       41           
  Lines        3352     3352           
=======================================
  Hits         3008     3008           
  Misses        344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392 adam2392 marked this pull request as ready for review October 17, 2023 14:51
adam2392 and others added 5 commits October 17, 2023 10:53
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 9ad065e into main Oct 17, 2023
24 checks passed
@adam2392 adam2392 deleted the citation branch October 17, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants