Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX add max_fpr argument to auc example #149

Merged
merged 1 commit into from
Oct 17, 2023
Merged

FIX add max_fpr argument to auc example #149

merged 1 commit into from
Oct 17, 2023

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Oct 17, 2023

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392
Copy link
Collaborator

LGTM once CI green

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (486e5a2) 89.73% compared to head (8f7d52f) 89.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          41       41           
  Lines        3352     3352           
=======================================
  Hits         3008     3008           
  Misses        344      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PSSF23 PSSF23 merged commit 983b846 into main Oct 17, 2023
25 checks passed
@adam2392 adam2392 deleted the fpr_fix branch October 17, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants