Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adding fix to allow any kind of tree for honesttree #158

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

adam2392
Copy link
Collaborator

Related to #157

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (a81c597) 89.77% compared to head (6b0423c) 88.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   89.77%   88.86%   -0.92%     
==========================================
  Files          41       41              
  Lines        3395     3439      +44     
==========================================
+ Hits         3048     3056       +8     
- Misses        347      383      +36     
Files Coverage Δ
sktree/tree/_honest_tree.py 99.43% <100.00%> (+0.01%) ⬆️
sktree/tree/tests/test_honest_tree.py 68.14% <16.27%> (-31.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit d6d0b16 into main Oct 27, 2023
23 checks passed
@adam2392 adam2392 deleted the allow-sktree branch October 27, 2023 19:34
@adam2392
Copy link
Collaborator Author

FYI @sampan501 these are the changes that I made to allow one to pass in sklearn's DecisionTree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant