[DOC] Adding notebooks for might/comight cancer #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #152
Closes: #176
Changes proposed in this pull request:
The bug basically meant that when we had more than 2 feature-sets, we have the following behavior:
with max_features = 0.3
n_features_per_view = [500, 500, 500]
feature_set_ends = [500, 1000, 1500]
max_feature_per_set_ = [150, 150, 300]
because max_feature_per_set_ = [500 * 0.3, 500 * 0.3, 1000 * 0.3], which was a basic programming error.
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting