Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add bug-fix for multi view splitter and updates submodule #183

Merged
merged 22 commits into from
Dec 6, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Dec 4, 2023

Fixes: #182
Fixes: #184
Supersedes: #181

Changes proposed in this pull request:

  • Update submodule
  • Fixes bug related to max_features in more than one feature view
  • Allows max_features to be an array-like, to allow specification of different sampling rates for split candidates across different feature views

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PSSF23 this should fix the issue raised in #182

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (2fa5a83) 90.64% compared to head (468523e) 90.18%.

❗ Current head 468523e differs from pull request most recent head 226a01a. Consider uploading reports for the commit 226a01a to get more accurate results

Files Patch % Lines
sktree/stats/monte_carlo.py 32.43% 25 Missing ⚠️
sktree/tree/_multiview.py 84.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   90.64%   90.18%   -0.46%     
==========================================
  Files          48       49       +1     
  Lines        4072     4198     +126     
==========================================
+ Hits         3691     3786      +95     
- Misses        381      412      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

adam2392 and others added 13 commits December 5, 2023 08:36
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 56d18fa into main Dec 6, 2023
21 of 23 checks passed
@adam2392 adam2392 deleted the cancer branch December 6, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants