Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Allow max sample without bootstrap in HonestForestClassifier #210

Merged
merged 12 commits into from
Feb 1, 2024

Conversation

adam2392
Copy link
Collaborator

Follow-up to #206

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
adam2392 and others added 7 commits January 31, 2024 16:36
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (4057b14) 88.29% compared to head (61d70bd) 88.27%.

❗ Current head 61d70bd differs from pull request most recent head e35f485. Consider uploading reports for the commit e35f485 to get more accurate results

Files Patch % Lines
sktree/ensemble/_honest_forest.py 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   88.29%   88.27%   -0.03%     
==========================================
  Files          50       50              
  Lines        4615     4640      +25     
==========================================
+ Hits         4075     4096      +21     
- Misses        540      544       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the metric name S@S98? It is S@98 in draft.

@adam2392
Copy link
Collaborator Author

adam2392 commented Feb 1, 2024

Why is the metric name S@S98? It is S@98 in draft.

I thought it was Sensitivity @ Specificity of 98? I'm indifferent to the naming as that can always change, so up to you all

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit aa655d6 into main Feb 1, 2024
3 checks passed
@adam2392
Copy link
Collaborator Author

adam2392 commented Feb 1, 2024

Moving to make release v0.6.1 to address issue of HonestForestClassifier getting validation checked on max_samples that wasn't caught on my machine

@adam2392 adam2392 deleted the permtree branch February 1, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants