-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow max sample without bootstrap in HonestForestClassifier
#210
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
- Coverage 88.29% 88.27% -0.03%
==========================================
Files 50 50
Lines 4615 4640 +25
==========================================
+ Hits 4075 4096 +21
- Misses 540 544 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the metric name S@S98
? It is S@98
in draft.
I thought it was Sensitivity @ Specificity of 98? I'm indifferent to the naming as that can always change, so up to you all |
Signed-off-by: Adam Li <adam2392@gmail.com>
Moving to make release v0.6.1 to address issue of HonestForestClassifier getting validation checked on |
Follow-up to #206
Changes proposed in this pull request:
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting