Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Fix HonestTreeClassifier and HonestForestClassifier to override all arguments passed to the underlying tree_estimator #228

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Feb 22, 2024

Fixes #224

Changes proposed in this pull request:

  • HonestTree and HonestForest now allow you to pass in relevant keyword arguments for trees that augment the existing BaseDecisionTree parameters (e.g. oblique tree and multi view tree)
  • Consolidates how multiviewtree is passed to HonestTree/Forest
  • Removed extraneous code by refactoring _get_n_samples_bootstrap in the scikit-learn fork

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 98.78049% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.74%. Comparing base (95e2597) to head (d1e9126).

Files Patch % Lines
sktree/ensemble/_honest_forest.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   89.68%   89.74%   +0.06%     
==========================================
  Files          54       54              
  Lines        4963     4936      -27     
==========================================
- Hits         4451     4430      -21     
+ Misses        512      506       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 9e571bf into main Feb 23, 2024
30 checks passed
@adam2392 adam2392 deleted the honestfix2 branch February 23, 2024 16:46
@adam2392
Copy link
Collaborator Author

Thanks for review @YuxinB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidation of the API for honest-tree and honest-forest
2 participants