Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, FIX] Allow scaling_factor in trunk_mixture_classification to be specified #234

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

adam2392
Copy link
Collaborator

Changes proposed in this pull request:

  • The covariance should be able to be specified, such that it is the identity matrix in trunk mixture.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (48ca383) to head (0cf395d).
Report is 2 commits behind head on main.

❗ Current head 0cf395d differs from pull request most recent head 7844529. Consider uploading reports for the commit 7844529 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files          54       54           
  Lines        5026     5029    +3     
=======================================
+ Hits         4514     4517    +3     
  Misses        512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 2/3 default? We don't have any simulations that use such scaling right now. Maybe in the future, but I would set the default to be identity.

@adam2392
Copy link
Collaborator Author

Why is 2/3 default? We don't have any simulations that use such scaling right now. Maybe in the future, but I would set the default to be identity.

cc: @sampan501 what was the reason again? Iforgot.

sktree/datasets/hyppo.py Outdated Show resolved Hide resolved
sktree/datasets/hyppo.py Outdated Show resolved Hide resolved
@sampan501
Copy link
Member

Why is 2/3 default? We don't have any simulations that use such scaling right now. Maybe in the future, but I would set the default to be identity.

cc: @sampan501 what was the reason again? Iforgot.

I had done that before because when making the visualization, using 1 doesn't look bimodal. So, I stuck with the Marron and Wand default. For the sake of this though, I think we should just use 1

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@sampan501 sampan501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending green CIs, lgtm

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 23e8c4c into main Feb 27, 2024
27 checks passed
@adam2392 adam2392 deleted the scaling branch February 27, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants