-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT Update submodule commit and remove cnp imports where possible #249
Conversation
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 90.05% 90.04% -0.02%
==========================================
Files 54 54
Lines 5050 5105 +55
==========================================
+ Hits 4548 4597 +49
- Misses 502 508 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc error and failing on AMD machines?
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
It should be fixed now |
Updates scikit-tree wrt scikit-learn fork
Changes proposed in this pull request:
cnp
import în Cython files where possible_update_tree
function to re-define a splitter (inefficient use of code tho; see Create an internal dictionary for BaseDecisionTree scikit-learn#64). This is done, so we don't have to pickle the splitter and builder and it works properly w/ the new code in submodule.X
.ParentInfo
andSplitRecord
when passing information back and forth between tree and splitter (see: MAINT Pass ParentInfo rather than explicit variables scikit-learn/scikit-learn#28614 (review))cc: @sampan501 @SUKI-O this may be useful for reviewing so you understand what Cython changes are happening
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.After submitting