Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX correct simulation class label for linear #254

Merged
merged 2 commits into from
Apr 17, 2024
Merged

FIX correct simulation class label for linear #254

merged 2 commits into from
Apr 17, 2024

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Apr 15, 2024

  • The class labels are reversed for the linear simulations

Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self: change tutorial after correction is in pip

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (6176df2) to head (c9e6c0f).

❗ Current head c9e6c0f differs from pull request most recent head 174ef96. Consider uploading reports for the commit 174ef96 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files          54       54           
  Lines        5105     5105           
=======================================
  Hits         4597     4597           
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll let you merge. Wanna also change the downstream PR to account for this?

Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to modify the tutorials and other possible problems. But only after it's in pip

@PSSF23 PSSF23 merged commit ee400da into main Apr 17, 2024
28 checks passed
@PSSF23 PSSF23 deleted the label_reverse branch April 17, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants