Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Clean up Cython files #321

Merged
merged 17 commits into from
Sep 9, 2024
Merged

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Sep 5, 2024

Reference Issues/PRs

Remove unused properties in Cython classes.

What does this implement/fix? Explain your changes.

Move fisher-yates shuffling to an inline function instead of a class method

Any other comments?

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.21%. Comparing base (1d970b0) to head (e0dc4a5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
treeple/neighbors.py 77.77% 1 Missing and 1 partial ⚠️
treeple/tree/_classes.py 97.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   80.00%   80.21%   +0.20%     
==========================================
  Files          24       24              
  Lines        2221     2254      +33     
  Branches      411      412       +1     
==========================================
+ Hits         1777     1808      +31     
- Misses        312      313       +1     
- Partials      132      133       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam2392 adam2392 merged commit 7e9dc22 into neurodata:main Sep 9, 2024
37 checks passed
@adam2392 adam2392 deleted the refactor-oblique branch September 9, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant