FEA Add warning to control against runtime might when wanting to run comight #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Li <adam2392@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 80.21% 80.25% +0.04%
==========================================
Files 24 24
Lines 2254 2259 +5
Branches 412 331 -81
==========================================
+ Hits 1808 1813 +5
Misses 313 313
Partials 133 133 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Adam Li <adam2392@gmail.com>
sampan501
requested changes
Oct 10, 2024
treeple/stats/forest.py
Outdated
| if covariate_index is None and isinstance(est.tree_estimator, MultiViewDecisionTreeClassifier): | ||
| warn( | ||
| "Covariate index is not defined, but a MultiViewDecisionTreeClassifier is used. " | ||
| "If using CoMIGHT, one should define the covariate index to permute." |
There was a problem hiding this comment.
I think we need a sentence here saying that MIGHT is being run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Any other comments?