-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bboxes sample data #231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 12 12
Lines 678 681 +3
=======================================
+ Hits 676 679 +3
Misses 2 2 ☔ View full report in Codecov by Sentry. |
ba0dc18
to
1f0ffdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sfmig! Minor suggestions and changes. I would also remove (3/4) from the PR title before merging.
Co-authored-by: Chang Huan Lo <changhuan.lo@ucl.ac.uk>
I also had a go at refactoring |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🚀 only held off by Anaconda issues
Description
What is this PR
Why is this PR needed?
We are adding a bounding boxes dataset and we need sample data to test it.
In the GIN repository for the test data, I added a sample VIA tracks file and updated the metadata file. To distinguish between pose and bounding boxes data, I added a
type
field in the metadata.yaml file.This PR adapts the code to take that into account.
What does this PR do?
Adapts the
sample_data
module to load the sample bounding boxes file.The data is not loaded yet as a dataset, since that is the focus of PR #229. As a result, that bit is not fully tested (yet), and codecov shows fail.
References
\
How has this PR been tested?
Tests pass locally and in CI.
Is this a breaking change?
We should be able to load old versions of the sample data, but I am not sure that is actually a functionality we want to support. Tests wouldn't pass with the old metadata file though (because we check the keys are the expected ones, which now include 'type').
Does this PR require an update to the documentation?
Yes, the CONTRIBUTING.md file has been updated.
Checklist: