-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration tests #295
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 15 15
Lines 909 909
=======================================
Hits 907 907
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @sfmig! I am onboard with all the changes, nothing to comment. LGTM!
c406952
to
1e03f0f
Compare
This reverts commit d67de0e.
Quality Gate passedIssues Measures |
Description
What is this PR
Why is this PR needed?
Updates integration tests to match recent changes to kinematic tests. Also simplifies one of the integration tests and factors part of it out as a unit test.
What does this PR do?
test_cart2pol_transform_on_kinematics
to better match the current kinematic tests (mainly to use datasets with easily derivable kinematics).test_nan_propagation_through_filters
into two tests:test_filter_with_nans_on_position_varying_window
) that counts the number of nans stays below the expected upper bound when applying a median filter or SG filter.References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: