Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute Heading #315

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

b-peri
Copy link
Collaborator

@b-peri b-peri commented Oct 3, 2024

Description

This PR introduces compute_heading(), a new function for computing "heading" to movement. Here, "heading" is defined as the signed angle between the animal's forward-facing vector and a reference vector. Following the convention established in our existing vector utility functions, the reference vector is [1, 0] (i.e. the positive x-axis) by default, but this can be changed by passing a 2D vector (as a list, tuple, or numpy.ndarray) to the reference_vector argument.

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

References

Closes #238

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.

Project coverage is 95.29%. Comparing base (bfb20d2) to head (246801e).

Files with missing lines Patch % Lines
movement/utils/vector.py 5.55% 34 Missing ⚠️
movement/analysis/kinematics.py 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   99.77%   95.29%   -4.49%     
==========================================
  Files          15       15              
  Lines         909      956      +47     
==========================================
+ Hits          907      911       +4     
- Misses          2       45      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@b-peri b-peri changed the title Compute Heading and Relative Heading Compute Heading Oct 4, 2024
Copy link

@niksirbi niksirbi requested review from sfmig and removed request for sfmig October 18, 2024 10:32
@vigji
Copy link
Collaborator

vigji commented Dec 10, 2024

related to #358 , what are your thoughts on heading in 3D? if you have any, posting here looking for people who might be interested in the option once we start having the first 3D data around

@@ -324,6 +328,86 @@ def compute_head_direction_vector(
)


def compute_heading(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to self: rename this to compute_heading_angle()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compute Head Direction and Angular Head Velocity
3 participants