-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute Heading #315
base: main
Are you sure you want to change the base?
Compute Heading #315
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 99.77% 95.29% -4.49%
==========================================
Files 15 15
Lines 909 956 +47
==========================================
+ Hits 907 911 +4
- Misses 2 45 +43 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
related to #358 , what are your thoughts on heading in 3D? if you have any, posting here looking for people who might be interested in the option once we start having the first 3D data around |
@@ -324,6 +328,86 @@ def compute_head_direction_vector( | |||
) | |||
|
|||
|
|||
def compute_heading( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to self: rename this to compute_heading_angle()
?
Description
This PR introduces
compute_heading()
, a new function for computing "heading" tomovement
. Here, "heading" is defined as the signed angle between the animal's forward-facing vector and a reference vector. Following the convention established in our existing vector utility functions, the reference vector is[1, 0]
(i.e. the positive x-axis) by default, but this can be changed by passing a 2D vector (as alist
,tuple
, ornumpy.ndarray
) to thereference_vector
argument.What is this PR
References
Closes #238
Checklist: