Fix for check-manifest pre-commit hook in Python 3.12

[sfmig]

Description

What is this PR

• Bug fix
• Addition of a new feature
• Other

Why is this PR needed?
With Python 3.12, pre-commit run check-manifest returns an error of missing dependencies -- see more details in this issue.

To fix it,wheel needs to be specified as a dependency of check-manifest in the pre-commit config.

This error doesn't show up in CI because:

• in CI, we run check-manifest with Python 3.10 and without the --no-build-isolation flag.
• the linting action runs on python 3.10

Question

• Right now, when we say we support Python 3.12 in practice we mean we run the code tests in Python 3.12.
• But should we ensure other bits, like the developer tools, also run on the Python versions we support?
• If so, maybe it makes sense if we ensure that the CI actions related to precommits run the latest python version?

What does this PR do?
Adds wheel as a dependency to check-manifest in the pre-commit config.

References

The most relevant is this issue. from the cookiecutter repo.

How has this PR been tested?

Tests pass locally and in CI.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

• The code has been tested locally
• Tests have been added to cover all new functionality
• The documentation has been updated to reflect any changes
• The code has been formatted with pre-commit

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (a3956c4) to head (534bc90).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #344   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          14       14           
  Lines         907      907           
=======================================
  Hits          905      905           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[niksirbi]

Thanks for this @sfmig!

Good to go as is, regarding your questions I don't have informed opinions, but here are my 2 cents anyway:

Right now, when we say we support Python 3.12 in practice we mean we run the code tests in Python 3.12.

I think that's what most Python projects mean, right?

But should we ensure other bits, like the developer tools, also run on the Python versions we support?

I'd say, yes. Our current docs for a development environment recommend Python 3.11, just because we tend to go for the "middle" one of the 3 supported versions at any given point, out of convention. That said, I'd say it's a reasonable expectation that dev would work for all of our supported Python versions (hence why this PR is good).

If so, maybe it makes sense if we ensure that the CI actions related to precommits run the latest python version?

Maybe, to catch cases like this one? But where would you make this change, here or in the actions repo? The problem with changing it in actions is that projects that rely on those may differ in their supported Python versions?

[niksirbi]

@sfmig is this ready to be merged?

[sfmig]

yes! Apologies, I think I will open a PR in the actions repo / ask other team members tomorrow about this (but that belongs to the other repo)