-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option for multiple views loading - take2 #346
Add the option for multiple views loading - take2 #346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 99.77% 99.78%
=======================================
Files 14 14
Lines 907 912 +5
=======================================
+ Hits 905 910 +5
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for re-opening this PR @vigji.
I think this is basically ready to go. I consider the new function sufficiently tested for what it does. If you find hiccups/stumbling blocks in day-to-day usage, you are welcome to fix them with additional PRs.
Regarding documentation, I think for now it would be sufficient to add the following snippet to the end of the "Dimensions and Coordinates" section of the "movement datasets" page:
:::{dropdown} Additional dimensions
:color: info
:icon: info
The above **dimensions** and **coordinates** are created
by default when loading a `movement` dataset from a single
file containing pose or bounding boxes tracks.
In some cases, you may encounter or create datasets with extra
**dimensions**. For example, the
{func}`movement.io.load_poses.from_multiview_files()` function
creates an additional `views` **dimension**,
with the **coordinates** being the names given to each camera view.
:::
This should render a dropdown like this:
Additional documentation, in form of an example, can be added later when we have some appropriate sample data and perhaps triangulation functionality.
With the above addition, I'll be happy to merge this.
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
Ok, this should have been taken care of now! |
Quality Gate passedIssues Measures |
174817d
Before submitting a pull request (PR), please read the contributing guide.
Just moving code from #197
Description
What is this PR
Why is this PR needed?
What does this PR do?
References
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: