-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs link check #80
Docs link check #80
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 8 8
Lines 308 308
=======================================
Hits 302 302
Misses 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic @lochhh! Will save us so much tume and headspace.
I have two comments:
-
Should we document this in the CONTRIBUTING guide? Perhaps mention in the Editind the documetation section that external urls should be added to conf.py
-
I found out I can run
sphinx-build -b linkcheck docs/source docs/build
locally to include link checking during the build. I have to add this to the relevant GitHub action, right?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This all seems to work fine now. Should we merge? |
yep. Thanks for the review! I'll rebase #79 once this is merged. |
Description
What is this PR
Why is this PR needed?
This PR
What does this PR do?
This PR
myst_url_schemes
inconf.py
.References
This PR addresses #75.
How has this PR been tested?
The docs have been built locally.
Does this PR require an update to the documentation?
We may want to add linkcheck as an option in the docs: building the docs locally and/or include this step in the GitHub build docs workflow.
Checklist: