-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to save multi-animal pose tracks to single-animal files #83
Ability to save multi-animal pose tracks to single-animal files #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very well done @DruvSkyy 🎉
I like the current implementation of this feature. Thanks to our back-and-forth, we converged on something sensible I think.
I have left some minor comments for you to implement.
After that, I'll modify the tests to cover the new funcitonality. Let's see if they'll help us discover any bugs/edge cases.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 98.19% 98.34% +0.14%
==========================================
Files 8 8
Lines 333 362 +29
==========================================
+ Hits 327 356 +29
Misses 6 6 ☔ View full report in Codecov by Sentry. |
Hey @DhruvSkyy, I've made the following modification to this PR:
Take a look at the new tests and see if you can make sense of them. I'm happy to discuss these 1-to-1 if some things are unclear. Other than that, this PR is now ready to merge I think, thanks a lot for your help! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
What is this PR
What does this PR do?
This PR adds the functionality to save xarrays as a dictionary of individual pandas dataframes for to_dlc_df and as multiple files for each individual for to_dlc_file. This is based on the split_individuals: bool parameter, if True it will split the data for each individual, if false it will save it as a multi-animal file.
References
This PR addresses Issue #39.
How has this PR been tested?
The PR was tested on a Juypter Notebook against the four scenarios, (credit to @niksirbi):
Todo
Need to write tests.
Checklist: