Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to preprocess a recording by group. This entails splitting the recording, applying preprocessing, and then aggregating at the end.
Initially, for each step the recording was split, preprocessed, then aggregated. However, this led to very slow behaviour when using the
get_traces()
function, it does not appearaggregate_channels
is best used in this way. Instead, the recording is split at the start. For each preporcessing step, the preproecssing is applied, and a aggregated version of the recording is stored onpreprocess_data
for provenance. However, the split recording are kept and each preprocessing step is applied to these separately. Then at the end, this split recording is finally reaggregated. This means that for each stored preprocessing step the data is aggregated and it is aggregated in the final step, but for each step the aggregation only happens once.