Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Add block_length param to dataset.interleave #175

Merged
merged 4 commits into from
Oct 12, 2021

Conversation

richford
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Resolves #174
This PR adds a block_length param to the dataset.interleave method. block_length should be set to the examples_per_shard that were used to write the original TFRecords dataset. Without this, get_data inadvertently shuffles its input data.

Checklist

  • I have added tests to cover my changes
  • I have updated documentation (if necessary)

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

@richford
Copy link
Contributor Author

I realize that you're waiting on me to add more unit tests for #177. Is there anything that I'm missing for this PR?

@satra satra merged commit 2630133 into neuronets:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_dataset shuffles data
2 participants