import3d_gui bugfix for HOC classes and top-level #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a test yet |
|
homebrew is broken today. So Mac OS test failures can be ignored. |
adamjhn
approved these changes
Apr 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #1159 +/- ##
==========================================
- Coverage 31.47% 31.40% -0.07%
==========================================
Files 571 571
Lines 108823 108825 +2
==========================================
- Hits 34248 34174 -74
- Misses 74575 74651 +76
Continue to review full report at Codecov.
|
|
Ugh. Looks like fine for Python classes and HOC classes but now not importing at top level.... |
ramcdougal
changed the title
This was referenced Apr 13, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
* import3d_gui bugfix for HOC classes * and support for top-level instantiation * HOC and toplevel import3d tests * instantiate fix, also some style changes * missed that commands can be added in mksubset * test edits following feedback from @adamjhn * more reasonable indenting for the HOC in a string * was missing a declaration of a variable type in hoc * path was wrong for asc file with HOC template test * 'this' doesn't exist in HOC by default * working import into HocTemplateTest * SectionLists do not have a length * workaround for issue #1164
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
* import3d_gui bugfix for HOC classes * and support for top-level instantiation * HOC and toplevel import3d tests * instantiate fix, also some style changes * missed that commands can be added in mksubset * test edits following feedback from @adamjhn * more reasonable indenting for the HOC in a string * was missing a declaration of a variable type in hoc * path was wrong for asc file with HOC template test * 'this' doesn't exist in HOC by default * working import into HocTemplateTest * SectionLists do not have a length * workaround for issue #1164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.