Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modlunit: Add CHARGE keyword and map it to VALENCE. #1508

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented Oct 19, 2021

modlunit gives an syntax error when USEION uses CHARGE instead of VALENCE.

@adamjhn adamjhn added the bug label Oct 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #1508 (c9a9ae8) into master (09c4408) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
+ Coverage   41.11%   41.20%   +0.08%     
==========================================
  Files         550      550              
  Lines      110261   110261              
==========================================
+ Hits        45336    45430      +94     
+ Misses      64925    64831      -94     
Impacted Files Coverage Δ
src/modlunit/init.cpp 100.00% <ø> (ø)
src/parallel/bbs.cpp 64.55% <0.00%> (+1.68%) ⬆️
src/parallel/bbssrv2mpi.cpp 56.14% <0.00%> (+3.74%) ⬆️
src/nrnmpi/bbsmpipack.cpp 86.15% <0.00%> (+11.28%) ⬆️
src/parallel/bbsclimpi.cpp 50.58% <0.00%> (+22.09%) ⬆️
src/parallel/bbssrvmpi.cpp 44.57% <0.00%> (+27.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c4408...c9a9ae8. Read the comment docs.

@pramodk pramodk requested a review from nrnhines October 21, 2021 23:21
@pramodk pramodk merged commit 9968fd7 into neuronsimulator:master Oct 22, 2021
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants