Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rxdmath problem with abs #1545

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Fix rxdmath problem with abs #1545

merged 1 commit into from
Nov 23, 2021

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented Nov 23, 2021

Semi-compile abs to fabs in rxdmath.

Semi-compile abs to fabs.
@adamjhn adamjhn added bug rxd reaction-diffusion labels Nov 23, 2021
@adamjhn adamjhn requested a review from ramcdougal November 23, 2021 19:51
@codecov-commenter
Copy link

Codecov Report

Merging #1545 (17fd28f) into master (114d097) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
+ Coverage   42.90%   42.98%   +0.08%     
==========================================
  Files         550      550              
  Lines      110410   110410              
==========================================
+ Hits        47369    47463      +94     
+ Misses      63041    62947      -94     
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/rxdmath.py 56.47% <ø> (ø)
src/parallel/bbs.cpp 64.55% <0.00%> (+1.68%) ⬆️
src/parallel/bbssrv2mpi.cpp 56.14% <0.00%> (+3.74%) ⬆️
src/nrnmpi/bbsmpipack.cpp 86.15% <0.00%> (+11.28%) ⬆️
src/parallel/bbsclimpi.cpp 50.58% <0.00%> (+22.09%) ⬆️
src/parallel/bbssrvmpi.cpp 44.57% <0.00%> (+27.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114d097...17fd28f. Read the comment docs.

@ramcdougal ramcdougal merged commit 36fc834 into master Nov 23, 2021
@ramcdougal ramcdougal deleted the rxdmath_fix branch November 23, 2021 20:49
alexsavulescu added a commit that referenced this pull request Jan 28, 2022
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants