Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxd doc updates including bio faq #1680

Merged
merged 22 commits into from
Mar 14, 2022
Merged

rxd doc updates including bio faq #1680

merged 22 commits into from
Mar 14, 2022

Conversation

ramcdougal
Copy link
Member

@ramcdougal ramcdougal commented Mar 7, 2022

Added text, explanation, and structure.

The main change is a significant update to https://nrn.readthedocs.io/en/latest/python/modelspec/programmatic/rxd.html#neuron-rxd

including the addition of a new page for rxdmath.

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #1680 (0b6680b) into master (e493506) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   45.30%   45.34%   +0.03%     
==========================================
  Files         551      551              
  Lines      111206   111206              
==========================================
+ Hits        50380    50424      +44     
+ Misses      60826    60782      -44     
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/export.py 0.00% <0.00%> (ø)
share/lib/python/neuron/rxd/node.py 77.75% <ø> (ø)
share/lib/python/neuron/rxd/species.py 78.78% <0.00%> (ø)
src/parallel/bbs.cpp 75.94% <0.00%> (+1.68%) ⬆️
src/parallel/bbssrvmpi.cpp 48.19% <0.00%> (+6.02%) ⬆️
src/parallel/bbsclimpi.cpp 58.13% <0.00%> (+8.13%) ⬆️
src/nrnmpi/bbsmpipack.cpp 93.33% <0.00%> (+10.76%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ramcdougal ramcdougal added the rxd reaction-diffusion label Mar 7, 2022
@ramcdougal ramcdougal requested a review from nrnhines March 7, 2022 23:24
@pramodk pramodk added this to the Release v8.1 milestone Mar 8, 2022
@ramcdougal
Copy link
Member Author

The documentation changes are temporarily visible at:
https://nrn.readthedocs.io/en/rxd-docs/

@pramodk
Copy link
Member

pramodk commented Mar 10, 2022

@adamjhn or @nrnhines: would you be taking a look at this before merge?

@ramcdougal ramcdougal changed the title rxd doc updates including bio faq rxd doc updates including bio faq -- do not merge just yet Mar 10, 2022
@ramcdougal
Copy link
Member Author

This was the one where I had an issue with the push the other day. The addition is contained to the end of the main rxd doc page. I'll resolve that when I go into the office.

@pramodk pramodk marked this pull request as draft March 10, 2022 16:04
@ramcdougal ramcdougal changed the title rxd doc updates including bio faq -- do not merge just yet rxd doc updates including bio faq Mar 13, 2022
@ramcdougal ramcdougal marked this pull request as ready for review March 14, 2022 01:37
@ramcdougal ramcdougal merged commit 0c7a48c into master Mar 14, 2022
@ramcdougal ramcdougal deleted the rxd-docs branch March 14, 2022 02:21
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants