-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable MUSIC support in NEURON #1896
Conversation
✔️ a987364b5154cb5230b55eacb0b029c0b29bb448 -> Azure artifacts URL |
✔️ aee0a29a565d62d72fe9297f68391ac79c1ce326 -> Azure artifacts URL |
Move around some of the tests and use find_path / find_library
also (temporarily) allow C++ MPI headers to see if things build
MUSIC won't be needing those much longer.
aee0a29
to
871bc1c
Compare
✔️ 871bc1c -> Azure artifacts URL |
Logfiles from GitLab pipeline #84050 (:no_entry:) have been uploaded here! Status and direct links: |
Logfiles from GitLab pipeline #84055 (:no_entry:) have been uploaded here! Status and direct links: |
Logfiles from GitLab pipeline #84056 (:white_check_mark:) have been uploaded here! Status and direct links: |
Logfiles from GitLab pipeline #84120 (:white_check_mark:) have been uploaded here! Status and direct links: |
✔️ 306a39d -> Azure artifacts URL |
Logfiles from GitLab pipeline #84127 (:no_entry:) have been uploaded here! Status and direct links: |
✔️ 0fc8fdd -> Azure artifacts URL |
@mdjurfeldt You mentioned in the README (Now in nrn/test/music_tests/README) that
I don't know details about gnu_getopt but if you skip one more...
works when
|
Logfiles from GitLab pipeline #85987 (:white_check_mark:) have been uploaded here! Status and direct links: |
Logfiles from GitLab pipeline #85988 (:white_check_mark:) have been uploaded here! Status and direct links: |
✔️ 1d012b5 -> Azure artifacts URL |
Logfiles from GitLab pipeline #86732 (:white_check_mark:) have been uploaded here! Status and direct links: |
✔️ f657fa6 -> Azure artifacts URL |
✔️ 7b93603 -> Azure artifacts URL |
* Enable MUSIC with -DNRN_ENABLE_MUSIC=ON * Improve the FindPackage module for MUSIC * ctest -R nrnmusic::music_tests Co-authored-by: Michael Hines <michael.hines@yale.edu> Co-authored-by: Mikael Djurfeldt <mikael@djurfeldt.com>
* Enable MUSIC with -DNRN_ENABLE_MUSIC=ON * Improve the FindPackage module for MUSIC * ctest -R nrnmusic::music_tests Co-authored-by: Michael Hines <michael.hines@yale.edu> Co-authored-by: Mikael Djurfeldt <mikael@djurfeldt.com>
* Enable MUSIC with -DNRN_ENABLE_MUSIC=ON * Improve the FindPackage module for MUSIC * ctest -R nrnmusic::music_tests Co-authored-by: Michael Hines <michael.hines@yale.edu> Co-authored-by: Mikael Djurfeldt <mikael@djurfeldt.com>
This relates to #1894
#2092 extends this to dynamic loading when NRN_ENABLE_MPI_DYNAMIC=ON
#2096 extends that to wheels.
MUSIC support was inadvertently dropped when we switched to CMake. We're fixing this oversight now. This is still a bit work in progress but we have added the FindPackage module and most of the CMake piping to get things built. Mostly what's left to do is:
OS/table.h
can be replaced with a standard data structure.so
or.a
library.