Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_flux for arithmeticed object #2687

Merged
merged 25 commits into from
May 31, 2024
Merged

include_flux for arithmeticed object #2687

merged 25 commits into from
May 31, 2024

Conversation

rgourdine
Copy link
Collaborator

closes #1088

@azure-pipelines Azure Pipelines
Copy link

✔️ 2994ef3 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 3bc3017 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ f3b093f -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ cc8bc56 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 325fdcb -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 798c640 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ aa8c8e4 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ d735f23 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 982af3b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 5e75e76 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ b8649cd -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (71bf299) to head (7615711).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2687   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files         563      563           
  Lines      104254   104265   +11     
=======================================
+ Hits        70059    70076   +17     
+ Misses      34195    34189    -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 251c0b2 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 8818d5a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
ramcdougal
ramcdougal requested changes May 24, 2024
View reviewed changes
share/lib/python/neuron/rxd/node.py Outdated Show resolved Hide resolved
share/lib/python/neuron/rxd/node.py Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 7615711 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #212780 (:white_check_mark:) have been uploaded here!

Status and direct links:

@ramcdougal ramcdougal merged commit 2af067f into master May 31, 2024
37 checks passed
@ramcdougal ramcdougal deleted the arith_object_flux branch May 31, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

Assignees
No one assigned
Labels
rxd reaction-diffusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node.include_flux should support _Arithmeticed objects
4 participants
@rgourdine @bbpbuildbot @ramcdougal @pramodk