Simplify breadth-first tree-traversal code in subtree1.
#3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
force-pushed
the
cornu/simplify_loop
branch
from
fc754f0 to
0a52b1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3261 +/- ##
==========================================
- Coverage 67.07% 67.06% -0.01%
==========================================
Files 571 571
Lines 111113 111110 -3
==========================================
- Hits 74531 74519 -12
- Misses 36582 36591 +9 ☔ View full report in Codecov by Sentry. |
|
✔️ 0a52b1b -> Azure artifacts URL |
|
✔️ c797c39 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
reviewed
Dec 3, 2024
|
So you prefer to keep the previous algorithm? |
|
My impression is that the proposed implementation is nicer, but the previous algorithm is more elegant. |
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
|
✔️ 06f7a64 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
1uc
changed the title
subtree1.
1uc
changed the title
subtree1.subtree1.
1uc
reviewed
Dec 4, 2024
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
1uc
approved these changes
Dec 4, 2024
|
|
✔️ 557a827 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.