Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int replaced by floor to accept negative coordinates. #3264

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

ceciliaromaro
Copy link
Contributor

No description provided.

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this; please remove the one comment and then it should be good.

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a test.

@ramcdougal ramcdougal added this to the Release v9.0 milestone Dec 2, 2024
Copy link

✔️ 6347c0b -> Azure artifacts URL

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (5fe797a) to head (a24c547).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3264   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111095   111096    +1     
=======================================
+ Hits        74521    74522    +1     
  Misses      36574    36574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link

sonarqubecloud bot commented Dec 2, 2024

Copy link

✔️ a24c547 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 95b14c9 into master Dec 3, 2024
36 checks passed
@ramcdougal ramcdougal deleted the ceciliaromaro-patch-1 branch December 3, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants