Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in ivocmain.cpp #3297

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Cleanup in ivocmain.cpp #3297

wants to merge 3 commits into from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Dec 19, 2024

No description provided.

@JCGoran JCGoran force-pushed the jelic/ivocmain_cleanup branch from 9d111ee to 42b438c Compare December 19, 2024 15:59
@JCGoran JCGoran force-pushed the jelic/ivocmain_cleanup branch from e019308 to 0f4f052 Compare December 19, 2024 16:20
Copy link

✔️ 78d8a9a -> Azure artifacts URL

@JCGoran JCGoran changed the title Cleanup in ivocmain Cleanup in ivocmain.cpp Dec 19, 2024
@JCGoran JCGoran marked this pull request as ready for review December 19, 2024 17:23
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (8dfe5a3) to head (78d8a9a).

Files with missing lines Patch % Lines
src/ivoc/ivocmain.cpp 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3297   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         571      571           
  Lines      111055   111060    +5     
=======================================
+ Hits        74487    74491    +4     
- Misses      36568    36569    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

}
char buf[256];
Sprintf(buf,
"Can't load NEURON resources from %s[aults]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block can be simplify with:

fmt::print("Can't load NEURON resources from {}[aults]\n", nrn_def_path1);

Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants