-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid using xcrun on non-osx platforms #710
Conversation
What's the best way of pulling your fix to my local repo, considering submodules under it? |
@ikitayama : this fix was done in neuron so we don't news to update submodule. You could have changed the branch from where I have created PR (i.e. pramodk/xcrun-fix). As this is merged into master, just do git pull to get latest master. |
I've re-ran CMake and built the code, but I still see the error. |
Am I supposed to use |
@ikitayama : did you run
For NEURON, we still use |
@pramodk I do too, but |
@ikitayama : if |
…les update on CPU/GPU (#710) * fixed for watch statements, global variable on GPU * fixed watch statement code generation described in #679 * fixed global variable update to gpu descrbed in #678 * fixed atomic capture for net_send buffer * fixed for watch test on GPU - Initial block was missing net_send_buffering related codegen when net_send was used - fix indentation with watch if-else statements - net_send_buffer updates from host & device missing - net_receieve_buffer code was out of place * Incorporate BlueBrain/mod2c/pull/63 * Fix CVF CI: INITIAL block shouldn't be executed on ISPC backend when mod file uses net_send/net_event method. This is because they contain non-compatible code for event buffering used for GPU. * Fix the weight_index argument for net_send_buffering() generated for net_send() call in INITIAL block. - See analysis in BlueBrain/nmodl#680 Closes #679, closes #678, closes #675, closes #680
fixes #709