_semi_compile raises Exception if bad state #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be impossible to ever reach the end of `_semi_compile`, however it was possible in older versions if there was an issue in model specification, so this explicitly catches any potential future issues at the `_semi_compile` stage. (Either way, the user eventually gets an exception but this is closer to the problematic point.)
nrnhines
pushed a commit
that referenced
this pull request
Dec 9, 2020
It should be impossible to ever reach the end of `_semi_compile`, however it was possible in older versions if there was an issue in model specification, so this explicitly catches any potential future issues at the `_semi_compile` stage. (Either way, the user eventually gets an exception but this is closer to the problematic point.)
nrnhines
pushed a commit
that referenced
this pull request
Dec 10, 2020
It should be impossible to ever reach the end of `_semi_compile`, however it was possible in older versions if there was an issue in model specification, so this explicitly catches any potential future issues at the `_semi_compile` stage. (Either way, the user eventually gets an exception but this is closer to the problematic point.)
olupton
added a commit
that referenced
this pull request
Dec 7, 2022
* Previously then when NMODL is built as a submodule of CoreNEURON the GitRevision.cmake helper from CoreNEURON was included. This makes things more explicit. * Also print summary at the end of CMake execution for all build system generators, not just Unix Makefiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be impossible to ever reach the end of
_semi_compile, however it was possible in older versions if there was an issue in model specification, so this explicitly catches any potential future issues at the_semi_compilestage. (Either way, the user eventually gets an exception but this is closer to the problematic point.)