Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript migration #34

Merged
merged 27 commits into from
Oct 23, 2020
Merged

TypeScript migration #34

merged 27 commits into from
Oct 23, 2020

Conversation

alexcastillo
Copy link
Collaborator

Includes:

  • All files have been migrated to TypeScript
  • New build process with TypeScript, Parcel and Rollup
  • Outputs ESM, CJS, UMD and Electron bundles (see readme)

Should fix #31 and #23

src/pipes/utility/addInfo.ts Show resolved Hide resolved
src/pipes/utility/addSignalQuality.ts Show resolved Hide resolved
src/pipes/utility/addInfo.ts Show resolved Hide resolved
@andrewjaykeller
Copy link
Contributor

Ship it!

@wtcross
Copy link

wtcross commented Oct 23, 2020

@alexcastillo, thank you for putting work into TypeScript support. Do you think we can get this merged in at some point soon? It was approved on Jan 16

@alexcastillo
Copy link
Collaborator Author

Sure, I'll make a release later today.

@alexcastillo alexcastillo merged commit 6ea95a6 into master Oct 23, 2020
@andrewjaykeller
Copy link
Contributor

Great work!!!!

@wtcross
Copy link

wtcross commented Oct 26, 2020

Thanks for this!

@alexcastillo
Copy link
Collaborator Author

alexcastillo commented Dec 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: eeg-pipes in React Native
4 participants