-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript migration #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpigeon
reviewed
Dec 20, 2018
FEAT: differences, means, center, standardization, absolutes, setc
Ship it! |
@alexcastillo, thank you for putting work into TypeScript support. Do you think we can get this merged in at some point soon? It was approved on Jan 16 |
Sure, I'll make a release later today. |
Great work!!!! |
Thanks for this! |
Hey Tyler,
I haven’t this issue before, but it does sound like a config issue.
Any luck so far?
Best,
Alex
…On Mon, Oct 26, 2020 at 8:55 AM Tyler Cross ***@***.***> wrote:
Thanks for this! I'm building a Svelte application using TypeScript and
Rollup as the module bundler. It appears that when I import the
@neurosity/pipes package with import { bandpassFilter, epoch, fft } from
***@***.***/pipes" I get the browser distribution, which requires parcel.
If I use import { bandpassFilter, epoch, fft } from
***@***.***/pipes/dist/esm" it compiles, but I get the following error in
the browser due to the dsp.js dependency:
dsp.js:60 Uncaught TypeError: Cannot read property 'Float64Array' of undefined
at setupTypedArray (dsp.js:60)
at dsp.js:77
at createCommonjsModule (index.mjs:1640)
at bandpassFilter.js:85
at main.ts:6
This is very likely an issue due to my rollup/typescript configuration,
but wanted to check to see if you know what the issue is.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJAPYR663LBFFCHOHYIUZLSMWEVBANCNFSM4GGGOM5Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Should fix #31 and #23