Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hints #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add type hints #3

wants to merge 1 commit into from

Conversation

devidw
Copy link

@devidw devidw commented Jul 1, 2022

  • Make sample data blocks in readme collapsable, add console link
  • Add dev container configuration files
  • Extend .gitignore
  • Add some doc comments
  • Add some type hints
  • Fix Instance attribute attribute_name defined outside init by setting instance properties as None inside __init__

I couldn't validate that all type hints are set correctly, but will definitely do so, as soon as my crown arrives. ✨

@andrewjaykeller
Copy link
Contributor

would love to merge this is you can rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants